By jumping to the corresponding line number, the finding of corresponding
i18n calls is accelerated.
FIXED-IN:18.12.2
BUG:403743
Details
Details
tested on linux
Diff Detail
Diff Detail
- Repository
- R456 Lokalize
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
| src/prefs/lokalize.kcfg | ||
|---|---|---|
| 95 | I don't think this should be enabled by default, you can't assume the user has Kate installed | |
| src/prefs/prefs_general.ui | ||
|---|---|---|
| 84 | I think those strings need to be translatable... I had read https://techbase.kde.org/Development/Tutorials/Localization/i18n and didn't see any I18N function here. If the strings is translatable but I don't know, just ignore it ;) | |
| src/prefs/prefs_general.ui | ||
|---|---|---|
| 84 | Strings in ui files are automatically picked up for translation so this is not an issue. | |
Comment Actions
Oh, no. Just ignore requested changes flag, I had do something wrong :/
| src/prefs/prefs_general.ui | ||
|---|---|---|
| 84 | Oh. Thanks for replying. :) | |
Comment Actions
This revision was not accepted when it landed; it landed in state Needs Review.
This is surprising because sdiepets accepted the request shortly before - I filed a bug report https://phabricator.kde.org/T10443
Comment Actions
It was not accepted, because ppeter's vote was still a rejection. Don't worry about that message. In the future, @ppeter , please use "Resign from review" function, or explicitly accept the review.