Differential D18641

[kio_applications] Fix last dir item being shown twice
ClosedPublic
Actions

Authored by kossebau on Feb 1 2019, 2:18 PM.

Details

Reviewers
chinmoyr
Group Reviewers
Plasma
Commits
R120:3431ea6dd1d2: [kio_applications] Fix last dir item being shown twice
Summary

During porting to the new KIO::SlaveBase::listEntry() API accidentally
the listEntry(entry, true) was turned into a listEntry(), where it
should have been just removed in favour of an existing finished() call.
See 0853202b0cfb688add4f021708830710e1b84931

Test Plan

applications: and programs: no longer show the last entry twice

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kossebau created this revision.Feb 1 2019, 2:18 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 1 2019, 2:18 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
kossebau requested review of this revision.Feb 1 2019, 2:18 PM
chinmoyr accepted this revision.Feb 5 2019, 3:31 PM
This revision is now accepted and ready to land.Feb 5 2019, 3:31 PM
Closed by commit R120:3431ea6dd1d2: [kio_applications] Fix last dir item being shown twice (authored by kossebau). · Explain WhyFeb 6 2019, 1:24 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 51011

View Options

kioslave/applications/kio_applications.cpp

Loading...