Differential D1863

Remove the first attempt to load library because we will try libraryPaths anyway
ClosedPublic
Actions

Authored by aspotashev on Jun 14 2016, 10:50 AM.

Details

Reviewers
dfaure
Group Reviewers
Frameworks
Commits
R317:74a807b1ea06: Remove the first attempt to load library because we will try libraryPaths anyway
Test Plan

The autotests in kross-interpreters still work after having installed kross into /usr/ (on Gentoo).

Diff Detail

Branch
remove-dupl-load-library
Lint
No Linters Available
Unit
No Unit Test Coverage
aspotashev updated this revision to Diff 4445.Jun 14 2016, 10:50 AM
aspotashev retitled this revision from to Remove the first attempt to load library because we will try libraryPaths anyway.
aspotashev updated this object.
aspotashev edited the test plan for this revision. (Show Details)
dfaure accepted this revision.Jun 14 2016, 3:59 PM
dfaure added a reviewer: dfaure.
dfaure added a subscriber: dfaure.

Looks good, assuming that libname is never an absolute path.... did you check that?

This revision is now accepted and ready to land.Jun 14 2016, 3:59 PM
aspotashev added a comment.Jun 14 2016, 6:28 PM

David,

libname is hardcoded for each scripting language at the moment to something like "krosspython" which is just shared object's basename. It's never an absolute path.

aspotashev closed this revision.Jun 26 2016, 8:01 PM

Revision Contents
Changeset List

PathPackages
Msrc/core/manager.cpp (41 lines)

Diff 4445

View Options

src/core/manager.cpp

Loading...