make kirigamiplugin also directly linkable
ClosedPublic
Actions

Authored by bearsh on Jun 14 2016, 9:20 AM.

Details

Reviewers

Summary

this makes it possible to simply put kirigami in a subfolder and include the .pri file in the parent project. everything get linked together.
this patch applies on mart/runtimeTheme

Diff Detail

Repository

R169 Kirigami

Lint

Lint Skipped

Unit

Unit Tests Skipped

bearsh updated this revision to Diff 4439.Jun 14 2016, 9:20 AM

bearsh retitled this revision from to make kirigamiplugin also directly linkable.

bearsh updated this object.

bearsh edited the test plan for this revision. (Show Details)

bearsh added a reviewer: mart.

bearsh set the repository for this revision to R169 Kirigami.

bearsh added a project: Kirigami.

Restricted Application added a subscriber: plasma-devel. · View Herald TranscriptJun 14 2016, 9:20 AM

apart minor cosmetic issues is good to go.

do you have permissions to push on git?

src/kirigamiplugin.h
71	i would call them resolveFilePath/resolveFileUrl also, implementation in the cpp with the { in new line

This revision is now accepted and ready to land.Jun 14 2016, 10:26 AM

rename toFile{Path,Url} to resolveFile{Path,Url} and fixed code style

In D1860#34489, @mart wrote:

do you have permissions to push on git?

no but I can get send-email it to you...

ok, you can send me a patch with git format-patch, o with git am i can push it with you as author.
for future ones, you gan do:
https://identity.kde.org/index.php?r=developerApplication

bearsh closed this revision.Jun 14 2016, 5:55 PM