Differential D18542

Use KAboutData to set information about the daemon
ClosedPublic
Actions

Authored by heikobecker on Jan 25 2019, 10:00 PM.

Details

Reviewers
nicolasfella
Group Reviewers
KDE Connect
Commits
R224:fab782d91c62: Use KAboutData to set information about the daemon
R224:989873595945: Use KAboutData to set information about the daemon
Summary

I noticed this when the daemon crashed and drkonqi refused to submit
a bug report, complaining about a missing bug reporting address.
Additionally, using KAboutData also saves initialising some
properties of QCoreApplication manually.

Test Plan

sent SIGSEGV to kdeconnect, could've reported the crash
with drkonqi; checked with GammaRay that the properties of
QCoreApplication are initialised.

Diff Detail

Repository
R224 KDE Connect
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
heikobecker created this revision.Jan 25 2019, 10:00 PM
Restricted Application added a project: KDE Connect. · View Herald TranscriptJan 25 2019, 10:00 PM
Restricted Application added a subscriber: kdeconnect. · View Herald Transcript
heikobecker requested review of this revision.Jan 25 2019, 10:00 PM
heikobecker added a comment.Jan 25 2019, 10:03 PM

Didn't add any copyright information or any author because I just didn't know who to put there.

nicolasfella accepted this revision.Jan 25 2019, 10:25 PM
nicolasfella added a subscriber: nicolasfella.

Thanks!

Please note that we recently switched to GitLab (https://invent.kde.org/kde/kdeconnect-kde), so please push there

This revision is now accepted and ready to land.Jan 25 2019, 10:25 PM
Closed by commit R224:fab782d91c62: Use KAboutData to set information about the daemon (authored by heikobecker). · Explain WhyJan 25 2019, 11:02 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mdaemon/kdeconnectd.cpp (12 lines)

Diff 50303

View Options

daemon/kdeconnectd.cpp

Loading...