Differential D18511

Provide debugger name and pid when registering a debugger to DrKonqi
ClosedPublic
Actions

Authored by croick on Jan 25 2019, 9:36 AM.

Details

Reviewers
mwolff
Group Reviewers
KDevelop
Commits
R32:7789fcd7be81: Provide debugger name and pid when registering a debugger to DrKonqi
Summary

Adapts the DBus call to the change in DrKonqi commit 9f3cfcff960c.

Test Plan

Use the debug button in DrKonqi to attach a crashed application
to a debugger in KDevelop.

Diff Detail

Repository
R32 KDevelop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
croick created this revision.Jan 25 2019, 9:36 AM
Restricted Application added a project: KDevelop. · View Herald TranscriptJan 25 2019, 9:36 AM
Restricted Application added a subscriber: kdevelop-devel. · View Herald Transcript
croick requested review of this revision.Jan 25 2019, 9:36 AM
croick added a comment.Jan 25 2019, 9:39 AM

Do you think we should check for the version of Plasma to make a distinction between DrKonqi versions?
I think not, the Debug feature is not (yet) very popular, but I would like another opinion.

mwolff accepted this revision.Jan 25 2019, 2:25 PM
mwolff added a subscriber: mwolff.

I think it's fine to commit this as-is

This revision is now accepted and ready to land.Jan 25 2019, 2:25 PM
Closed by commit R32:7789fcd7be81: Provide debugger name and pid when registering a debugger to DrKonqi (authored by croick). · Explain WhyJan 26 2019, 11:01 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 50356

View Options

plugins/debuggercommon/midebuggerplugin.cpp

Loading...