add direction choice to the imagesplit
ClosedPublic

Authored by nolanfa on Jan 21 2019, 11:50 PM.

Details

Summary

One use-case for the imagesplit is modifying spritesheet found externally (for example on the internet): splitting them then re-importing them in the animation timeline lets you use the dedicated animation tools, like the onionskin, and easily preview the animation with your modifications.
But most spritesheet found on the internet are horizontal, like so:
1, 2, 3
4, 5, 6
while a few are vertical, like so:
1, 3, 5
2, 4, 6

Adding a button to choose which is more appropriate lets the imagesplit be used in both cases and still name the individual images correctly.
I put the default at horizontal, while it was at vertical before, because it seems more widely used.

Diff Detail

Repository
R37 Krita
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nolanfa created this revision.Jan 21 2019, 11:50 PM
Restricted Application added a reviewer: Krita. · View Herald TranscriptJan 21 2019, 11:50 PM
Restricted Application added a project: Krita. · View Herald Transcript
nolanfa requested review of this revision.Jan 21 2019, 11:50 PM
nolanfa updated this revision to Diff 50051.Tue, Jan 22, 10:27 AM

made some variables more local

rempt accepted this revision.Wed, Jan 23, 8:34 AM
rempt added a subscriber: rempt.

Works fine. I see there's some layout weirdness in the ui file, though, but I'll check that now. I guess you don't have a kde committer account? I can push this for you if you can let me know your name and email address for the commit message.

This revision is now accepted and ready to land.Wed, Jan 23, 8:34 AM

The dialog after the patch seem to work. The only trouble I saw is some debugging output, it is seem to have been present before the patch. Can be removed though :)

Yeah, I didn't quite know which layout worked best, I did a few tests and chose one kind of at random.
No, I don't have a committer account. My name is noemie scherer, my email: noemie . scherer (at) gmail . com
Thanks!

This revision was automatically updated to reflect the committed changes.

Thanks and congrats -- your first patch has landed :-)