The length binding was assigning a value to the length property during the property evaluation.
Also, containment might be null which was never checked for causing a runtime warning.
Details
Details
- Reviewers
mart - Group Reviewers
Plasma - Commits
- R119:52b4809728bf: [Panel] Fix warning and don't cause side-effects in binding
Added vertical panel, centered it, put task manager in there, panel would still automatically shrink and grow depending on the number of windows shown
Diff Detail
Diff Detail
- Repository
- R119 Plasma Desktop
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Use "when" to not mess with the panel length until we have a containment.
Otherwise we would start and briefly have the panel at 0 size which looks ugly. This probably was concealed by the old code just throwing an exception when it tried to access formFactor on null containment