Fix launching Okular by opening a document from the file browser
ClosedPublic

Authored by vkrause on Jan 19 2019, 9:25 PM.

Details

Summary

There's two issues here:

  • Activity::onCreate triggered before the C++ side was loaded, so the call to C++ failed (causing a crash). So delay that until we are ready.
  • The static instance of URIHandler in the header caused it to duplicate into each translation unit, causing main.cpp to not see what android.cpp wrote into it.

Diff Detail

Repository
R223 Okular
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
vkrause created this revision.Jan 19 2019, 9:25 PM
Restricted Application added a project: Okular. · View Herald TranscriptJan 19 2019, 9:25 PM
Restricted Application added a subscriber: okular-devel. · View Herald Transcript
vkrause requested review of this revision.Jan 19 2019, 9:25 PM
aacid accepted this revision.Feb 2 2019, 3:18 PM
This revision is now accepted and ready to land.Feb 2 2019, 3:18 PM
This revision was automatically updated to reflect the committed changes.