Add a prop to toggle the special grouping behavior for tasks in demanding-attention state.
ClosedPublic
Actions

Authored by hein on Jun 13 2016, 8:15 AM.

Details

Reviewers

Commits

Summary

This is needed for subsequent feature work which needs to be able
to turn this off.

This review also includes a number of bug fixes to the model:

Fix an off-by-one when explicitly breaking a group apart.
Fix rowCount() returning the value for a top-level item with the same row when called for a group member.
Fix updating/invalidating persistent indices endRemoveRows() doesn't know how to handle.
Update data for former parent item ahead of child-reparenting insert when breaking a group apart.

None of these fixes actually matter for the applet view, but
they obviously improve correctness, and will matter for later
work.

Repository

R120 Plasma Workspace

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

hein retitled this revision from to Add a prop to toggle the special grouping behavior for tasks in demanding-attention state..

hein updated this object.

hein edited the test plan for this revision. (Show Details)

hein added a reviewer: davidedmundson.

hein added a subscriber: plasma-devel.

davidedmundson edited edge metadata.

This revision is now accepted and ready to land.Jun 13 2016, 8:47 AM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			libtaskmanager/taskgroupingproxymodel.h (23 lines)
M			libtaskmanager/taskgroupingproxymodel.cpp (102 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	4375	6c0b1e5		Jun 13 2016, 8:15 AM	★	★
Diff 2	4381	6c0b1e5	rPLASMAWORKSPACE00fb293d7963e9d077aa59d4f642261e4210bc91	Jun 13 2016, 8:15 AM	★	★