Add "R&D" type test, to investigate if KDateTime is still needed.
ClosedPublic

Authored by dfaure on Jun 13 2016, 8:11 AM.

Details

Summary

Indeed it is: if one day we want to differenciate between an "all day"
event and a start datetime at midnight, then a single QDateTime value isn't enough.

KDateTime has allDay(), while QDateTime converts null (or invalid) times to midnight.

This is probably why KCalCore still uses KDateTime. So if zanshin wants to support
todos with a specific start time, it has to either use KDateTime (i.e. kdelibs4support)
everywhere (starting with domain/task.h), or to wait until KCalCore is (somehow)
ported away from KDateTime (e.g. with its own bool - or QDateTime needs extending).

Diff Detail

Repository
R4 Zanshin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
dfaure updated this revision to Diff 4371.Jun 13 2016, 8:11 AM
dfaure retitled this revision from to Add "R&D" type test, to investigate if KDateTime is still needed..
dfaure updated this object.
dfaure edited the test plan for this revision. (Show Details)
dfaure added a reviewer: ervin.
ervin edited edge metadata.Jun 28 2016, 4:02 PM

Small nitpick, could you please put this test all the way at the end of this test suite? Just to keep concerns somewhat separated.

ervin requested changes to this revision.Jun 28 2016, 4:02 PM
ervin edited edge metadata.
This revision now requires changes to proceed.Jun 28 2016, 4:02 PM
This revision was automatically updated to reflect the committed changes.

OK - changed and pushed.