Differential D18343

[wallpapers/image] Port wallpaper plugins (mostly) to QQC2
ClosedPublic
Actions

Authored by ngraham on Jan 17 2019, 11:43 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R120:7e6d0c0b0eeb: [wallpapers/image] Port wallpaper plugins (mostly) to QQC2
Summary

BUG: 400549
FIXED-IN: 5.15.0

Test Plan

On the lock screen KCM at 1.2x scale, before:

After:

All functionality continues to work on the lock screen and SDDM KCMs and desktop containment window.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Jan 17 2019, 11:43 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 17 2019, 11:43 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Jan 17 2019, 11:43 PM
ngraham edited the test plan for this revision. (Show Details)Jan 17 2019, 11:45 PM
ngraham edited the test plan for this revision. (Show Details)Jan 17 2019, 11:54 PM
davidedmundson added a subscriber: davidedmundson.Jan 18 2019, 12:13 AM

If you want to push everything except the combobox go for it.
QQC allows us to mix, we should make use of that to do regression-free ports.

wallpapers/image/imagepackage/contents/ui/config.qml
93

And now we've replaced this bug report with a new one about resizing the menu to contents.

I think that'll affect a lot more users.

ngraham updated this revision to Diff 49779.Jan 18 2019, 12:38 AM
ngraham marked an inline comment as done.

Keep the QQC1 version of the ComboBox until we've fixed tps://bugs.kde.org/show_bug.cgi?id=403153

ngraham added a comment.Jan 18 2019, 12:39 AM

Good call David!

ngraham retitled this revision from [Imagepackage] Port wallpaper plugins to QQC2 to [Imagepackage] Port wallpaper plugins (mostly) to QQC2.Jan 18 2019, 12:39 AM
ngraham retitled this revision from [Imagepackage] Port wallpaper plugins (mostly) to QQC2 to [wallpapers/image] Port wallpaper plugins (mostly) to QQC2.Jan 18 2019, 2:51 AM
davidedmundson accepted this revision.Jan 18 2019, 11:11 AM
This revision is now accepted and ready to land.Jan 18 2019, 11:11 AM
Closed by commit R120:7e6d0c0b0eeb: [wallpapers/image] Port wallpaper plugins (mostly) to QQC2 (authored by ngraham). · Explain WhyJan 18 2019, 3:05 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 49823

View Options

wallpapers/image/imagepackage/contents/ui/config.qml

Loading...