Differential D18298

Use androidx version of AlertDialog
ClosedPublic
Actions

Authored by eduisters on Jan 16 2019, 3:11 PM.

Details

Reviewers
albertvaka
Group Reviewers
KDE Connect
Commits
R225:8e93e3253fbb: Use androidx version of AlertDialog
Summary

Use androidx version of AlertDialog to get properly styled AlertDialog buttons
Use PreferenceManager context to style Device Name AlertDialog

BeforeAfter
Test Plan

Apply patch and verify that AlertDialogs have properly styled buttons

Diff Detail

Repository
R225 KDE Connect - Android application
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
eduisters created this revision.Jan 16 2019, 3:11 PM
Restricted Application added a project: KDE Connect. · View Herald TranscriptJan 16 2019, 3:11 PM
Restricted Application added a subscriber: kdeconnect. · View Herald Transcript
eduisters requested review of this revision.Jan 16 2019, 3:11 PM
eduisters edited the summary of this revision. (Show Details)Jan 16 2019, 3:16 PM
eduisters added a reviewer: KDE Connect.
albertvaka accepted this revision.Jan 17 2019, 11:26 AM
albertvaka added a subscriber: albertvaka.

Cool!

This revision is now accepted and ready to land.Jan 17 2019, 11:26 AM
Closed by commit R225:8e93e3253fbb: Use androidx version of AlertDialog (authored by eduisters). · Explain WhyJan 17 2019, 4:21 PM
This revision was automatically updated to reflect the committed changes.

Showing Only Differences

This revision modifies 7 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

Diff 49729

View Options

src/org/kde/kdeconnect/UserInterface/SettingsFragment.java

Loading...