Differential D18297

[kcmkwin/kwindesktop] Remove pointless layout container
ClosedPublic
Actions

Authored by davidedmundson on Jan 16 2019, 2:33 PM.

Details

Reviewers
broulik
Group Reviewers
KWin
Commits
R108:e6b5903fffab: [kcmkwin/kwindesktop] Remove pointless layout container
Summary

ColumnLayout only contains one item so is rather pointless, but more
importantly prevents size hints from the formLayout propogating up to
the ScrollViewKCM.

Test Plan

Opened KCM

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.Jan 16 2019, 2:33 PM
Restricted Application added a project: KWin. · View Herald TranscriptJan 16 2019, 2:33 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
davidedmundson requested review of this revision.Jan 16 2019, 2:33 PM
broulik accepted this revision.Jan 16 2019, 2:58 PM
This revision is now accepted and ready to land.Jan 16 2019, 2:58 PM
Closed by commit R108:e6b5903fffab: [kcmkwin/kwindesktop] Remove pointless layout container (authored by davidedmundson). · Explain WhyJan 16 2019, 3:16 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 49645

View Options

kcmkwin/kwindesktop/package/contents/ui/main.qml

Loading...