Differential D18280

Locking plot to be moved or zoomed
ClosedPublic
Actions

Authored by Murmele on Jan 15 2019, 9:00 PM.

Details

Reviewers
asemke
Summary

Locking plot, so it cannot be moved inadvertend. Saving this option in the project file.
Saving also the cartesianplotaction mode in the project file

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped
Murmele created this revision.Jan 15 2019, 9:00 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptJan 15 2019, 9:00 PM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
Murmele requested review of this revision.Jan 15 2019, 9:00 PM
Murmele updated this revision to Diff 49840.Jan 18 2019, 8:53 PM
Murmele updated this revision to Diff 49843.Jan 18 2019, 9:40 PM

add tooltip

asemke added inline comments.Jan 19 2019, 9:03 AM
src/backend/worksheet/Worksheet.h
81 ↗(On Diff #49572)

isLocked() is a better name.

83 ↗(On Diff #49572)

setLocked(bool) is a better name.

src/backend/worksheet/WorksheetPrivate.h
78 ↗(On Diff #49572)

we don't need to mention 'Plot' in the member variable of the plot. Let's simply use 'bool locked'.

asemke accepted this revision.Jan 19 2019, 10:03 AM

I'll push your change with those couple of changes mentioned in the review.

This revision is now accepted and ready to land.Jan 19 2019, 10:03 AM
aacid added a subscriber: aacid.Jul 21 2019, 5:27 PM

@asemke Was this ever commited?

asemke added a comment.Dec 6 2019, 8:23 PM
In D18280#499352, @aacid wrote:

@asemke Was this ever commited?

yes, this was commited in 1c103f76. The commit message was a bit wrong so this review wasn't automatically closed. I'm closing it now.

asemke closed this revision.Dec 6 2019, 8:23 PM

Showing Only Differences

This revision modifies 4 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

Diff 49840

View Options

src/backend/worksheet/Worksheet.h

Loading...
View Options

src/backend/worksheet/WorksheetPrivate.h

Loading...
View Options

src/commonfrontend/worksheet/WorksheetView.h

Loading...
View Options

src/commonfrontend/worksheet/WorksheetView.cpp

Loading...