Add properties to column
AcceptedPublic

Authored by Murmele on Jan 15 2019, 8:53 PM.

Details

Reviewers
asemke
Summary

Possible to speed up some algorithms

Diff Detail

Repository
R262 LabPlot
Lint
Lint Skipped
Unit
Unit Tests Skipped
Murmele created this revision.Jan 15 2019, 8:53 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptJan 15 2019, 8:53 PM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
Murmele requested review of this revision.Jan 15 2019, 8:53 PM

Thanks in advance for fixing minor documentation issues.

src/backend/core/AbstractColumn.cpp
545 ↗(On Diff #49571)

Doxygen's \brief is for classes, structures, etc. This line is redundant. It is sufficient to begin with the next line.

548 ↗(On Diff #49571)

No need to write \return if there will be no description of the returned value.

src/backend/core/column/Column.cpp
482 ↗(On Diff #49571)

For Doxygen to work, this should be

\see AbstractColumn::properties
483 ↗(On Diff #49571)

No need to write \return if there will be no description of the returned value.

src/backend/core/column/ColumnPrivate.cpp
1216 ↗(On Diff #49571)

Doxygen's \brief is for classes, structures, etc. This line is redundant. It is sufficient to begin with the next line.

asemke added inline comments.Jan 15 2019, 9:14 PM
src/backend/core/AbstractColumn.cpp
547 ↗(On Diff #49571)

We'll need to change this "will be used" to "is used" later.

src/backend/core/column/ColumnPrivate.cpp
1311 ↗(On Diff #49571)

can we have this return already in the if-else block before this for-loop? Then we don't need to have this check inside the loop. Also, we should maybe set propertiesAvailable to true if we return for unsupported data types so we don't call this function again and again.

src/backend/core/column/ColumnPrivate.h
117 ↗(On Diff #49571)

int? Why not Properties?

Murmele updated this revision to Diff 49578.Jan 15 2019, 10:03 PM
Murmele updated this revision to Diff 49579.
Murmele updated this revision to Diff 49580.Jan 15 2019, 10:09 PM
Murmele updated this revision to Diff 49581.
Murmele marked 2 inline comments as done.
Murmele marked 6 inline comments as done.Jan 15 2019, 10:22 PM
Murmele updated this revision to Diff 49611.Jan 16 2019, 10:59 AM

set properties available to true, when not handled columnmode

asemke accepted this revision.Jan 16 2019, 12:07 PM
This revision is now accepted and ready to land.Jan 16 2019, 12:07 PM
aacid added a subscriber: aacid.Jan 16 2019, 10:51 PM

Is it me or this doesn't apply to master?

asemke added a comment.Dec 6 2019, 8:48 PM

Is it me or this doesn't apply to master?

this was finalized and submitted in 88c4771c.