Fix autohide behaviour after dragging a panel
ClosedPublic

Authored by scoenen on Fri, Jan 11, 5:59 PM.

Details

Summary

Currently, when dragging a window from the panel to move it, it breaks the autohide behaviour of active docks/panels. This change imitates a release event on X11 to circumvent these problems.

BUG: 403104

Diff Detail

Repository
R878 Latte Dock
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
scoenen created this revision.Fri, Jan 11, 5:59 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFri, Jan 11, 5:59 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
scoenen requested review of this revision.Fri, Jan 11, 5:59 PM
mvourlakos edited the summary of this revision. (Show Details)Fri, Jan 11, 6:12 PM
mvourlakos added a reviewer: mvourlakos.

Can you update your diff with ?

I moved the X code under xwindowinterface which feels better to be and I fixed also the mouse positioning when the drag is started

scoenen updated this revision to Diff 49286.Fri, Jan 11, 7:47 PM

I updated the diff as you asked. Just one minor thing: Calling View::restoreGrabItemBehavior() under X11 seems to be redundant now.

mvourlakos accepted this revision.Fri, Jan 11, 10:36 PM

I updated the diff as you asked. Just one minor thing: Calling View::restoreGrabItemBehavior() under X11 seems to be redundant now.

We can apply that as it is and in a second request to remove any code of the old approach that is not needed. Can you provide an email address in order for me to commit it for you?

This revision is now accepted and ready to land.Fri, Jan 11, 10:36 PM

You can use this email address: steffen@steffen-coenen.de

As for the potentially redundant code on X11, I am not sure if there is any benefit in changing it any further as it works as it is. It just checks if a mouseGrabberItem() is present which should never be the case on X11 now and then does nothing.

This revision was automatically updated to reflect the committed changes.