Currently, when dragging a window from the panel to move it, it breaks the autohide behaviour of active docks/panels. This change imitates a release event on X11 to circumvent these problems.
BUG: 403104
mvourlakos |
Currently, when dragging a window from the panel to move it, it breaks the autohide behaviour of active docks/panels. This change imitates a release event on X11 to circumvent these problems.
BUG: 403104
Automatic diff as part of commit; lint not applicable. |
Automatic diff as part of commit; unit tests not applicable. |
Can you update your diff with ?
I moved the X code under xwindowinterface which feels better to be and I fixed also the mouse positioning when the drag is started
I updated the diff as you asked. Just one minor thing: Calling View::restoreGrabItemBehavior() under X11 seems to be redundant now.
We can apply that as it is and in a second request to remove any code of the old approach that is not needed. Can you provide an email address in order for me to commit it for you?
You can use this email address: steffen@steffen-coenen.de
As for the potentially redundant code on X11, I am not sure if there is any benefit in changing it any further as it works as it is. It just checks if a mouseGrabberItem() is present which should never be the case on X11 now and then does nothing.