Differential D1811

UpdateClientArea from ShellClient::doSetGeometry if the ShellClient has a strut
ClosedPublic
Actions

Authored by graesslin on Jun 10 2016, 8:52 AM.

Details

Reviewers
bshah
Group Reviewers
Plasma on Wayland
KWin
Commits
R108:2343a90aa517: UpdateClientArea from ShellClient::doSetGeometry if the ShellClient has a strut
Summary

This ensures that resizing a panel updates the client area. On X11 there
is an event when the struts change, but on Wayland the struts are implied
from window type (panel) and the panel behavior, so we need to trigger it
manually.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
graesslin updated this revision to Diff 4320.Jun 10 2016, 8:52 AM
graesslin retitled this revision from to UpdateClientArea from ShellClient::doSetGeometry if the ShellClient has a strut.
graesslin updated this object.
graesslin edited the test plan for this revision. (Show Details)
graesslin added reviewers: KWin, Plasma on Wayland.
Restricted Application added projects: Plasma on Wayland, KWin. · View Herald TranscriptJun 10 2016, 8:52 AM
Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript
bshah accepted this revision.Jun 10 2016, 9:56 AM
bshah added a reviewer: bshah.
This revision is now accepted and ready to land.Jun 10 2016, 9:56 AM
graesslin added a comment.Jun 10 2016, 10:56 AM

Just as an fyi: I added a test case to expose the actual problem to the change which I'll now push.

Closed by commit R108:2343a90aa517: UpdateClientArea from ShellClient::doSetGeometry if the ShellClient has a strut (authored by graesslin). · Explain WhyJun 10 2016, 10:57 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mautotests/wayland/struts_test.cpp (50 lines)
Mshell_client.cpp (3 lines)

Diff 4325

View Options

autotests/wayland/struts_test.cpp

Loading...
View Options

shell_client.cpp

Loading...