Differential D1799

Add missing hasChildren() implementation.
ClosedPublic
Actions

Authored by hein on Jun 8 2016, 11:20 AM.

Details

Reviewers
graesslin
Group Reviewers
Plasma
Commits
R120:2d7b6692d364: Add missing hasChildren() implementation.
R871:2d7b6692d364: Add missing hasChildren() implementation.
Summary

QAbstractProxyModel forwards hasChildren() to the source model, which
will return a wrong value for our tree-restructuring model. Current
views/proxies don't call hasChildren(), which is how this oversight
happened, but implementing it improves model hygiene - could blow up
in the future otherwise.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
hein updated this revision to Diff 4291.Jun 8 2016, 11:20 AM
hein retitled this revision from to Add missing hasChildren() implementation..
hein updated this object.
hein edited the test plan for this revision. (Show Details)
hein added a reviewer: Plasma.
hein added a subscriber: plasma-devel.
Restricted Application added a project: Plasma. · View Herald TranscriptJun 8 2016, 11:20 AM
graesslin accepted this revision.Jun 9 2016, 5:53 AM
graesslin added a reviewer: graesslin.
This revision is now accepted and ready to land.Jun 9 2016, 5:53 AM
Closed by commit R120:2d7b6692d364: Add missing hasChildren() implementation. (authored by hein). · Explain WhyJun 10 2016, 10:56 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 4324

View Options

libtaskmanager/taskgroupingproxymodel.h

Loading...
View Options

libtaskmanager/taskgroupingproxymodel.cpp

Loading...