Differential D17941

Fix lowercase typo in XML file indidrivers.xml
ClosedPublic
Actions

Authored by tstibor on Jan 3 2019, 2:31 PM.

Details

Reviewers
mutlaqja
yurchor
Summary

Compiling (master) and starting kstars leads to message output:

...
org.kde.kstars: "Object named Mathilde not found"
org.kde.kstars: "Object named Eros (1898 DQ) not found"
org.kde.kstars: "Object named Hektor (1907 XM) not found"
org.kde.kstars: "Object named Chiron (1977 UB) not found"
org.kde.kstars: "Object named Halley (1982 HG1) not found"
<driverslist>
    <devgroup group="Telescopes">
        <device label="Starbook" manufacturer="Vixen">
            <driver name="Starbook">
indi_starbook_telescope
            </driver>
            <version>
0.2
            </version>
        </device>
    </devgroup>
</driverslist>
...

The XML output message is shown (probably) due to lowercase typo of TAG <driverslist> and <devgroup>
In XML file indidrivers.xml the TAG is except this case, consistently written as <driversList> <devGroup>

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped
tstibor created this revision.Jan 3 2019, 2:31 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptJan 3 2019, 2:31 PM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
tstibor requested review of this revision.Jan 3 2019, 2:31 PM
tstibor updated this revision to Diff 48601.Jan 3 2019, 2:34 PM
tstibor edited the summary of this revision. (Show Details)
yurchor accepted this revision.Jan 3 2019, 2:37 PM

Thanks.

This revision is now accepted and ready to land.Jan 3 2019, 2:37 PM
mutlaqja added a comment.Jan 3 2019, 2:39 PM

THanks, but this needs to be fixed at INDI side, not KStars. I will fix that in INDI and sync KStars. there is a script that syncs them.

tstibor added a comment.Jan 3 2019, 2:45 PM

Ahh ok, I see, it must be fixed in ./3rdparty/indi-starbook/indi_starbook_telescope.xml.cmake

<?xml version="1.0" encoding="UTF-8"?>
<driverslist>
    <devgroup group="Telescopes">
        <device label="Starbook" manufacturer="Vixen">
            <driver name="Starbook">indi_starbook_telescope</driver>
            <version>@STARBOOK_DRIVER_VERSION_MAJOR@.@STARBOOK_DRIVER_VERSION_MINOR@</version>
        </device>
    </devgroup>
</driverslist>
mutlaqja closed this revision.Jan 3 2019, 2:48 PM

Fix in KStars.

Revision Contents
Changeset List

PathPackages
Mkstars/data/indidrivers.xml (8 lines)

Diff 48601

View Options

kstars/data/indidrivers.xml

Loading...