Differential D17901

"Zero as null pointer constant" warnings fixed
ClosedPublic
Actions

Authored by gassaf on Jan 1 2019, 5:12 PM.

Details

Reviewers
cfeck
teran
Commits
R353:c77175cd2d90: "Zero as null pointer constant" warnings fixed
Summary

Fixes all "Zero as null pointer constant" warnings by using C++11 nullptr

Diff Detail

Repository
R353 KCalc
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
gassaf created this revision.Jan 1 2019, 5:12 PM
Restricted Application added a subscriber: kde-utils-devel. · View Herald TranscriptJan 1 2019, 5:12 PM
gassaf requested review of this revision.Jan 1 2019, 5:12 PM
gassaf edited the summary of this revision. (Show Details)Jan 1 2019, 5:15 PM
cfeck accepted this revision.Jan 2 2019, 12:03 AM
cfeck added a reviewer: teran.
cfeck added a subscriber: cfeck.
cfeck added inline comments.
kcalc.cpp
682

Note to self: Check why margin is limited to 3.

This revision is now accepted and ready to land.Jan 2 2019, 12:03 AM
Closed by commit R353:c77175cd2d90: "Zero as null pointer constant" warnings fixed (authored by gassaf). · Explain WhyJan 7 2019, 8:47 PM
This revision was automatically updated to reflect the committed changes.
cfeck added a comment.Jan 7 2019, 9:11 PM

You committed a different (wrong) patch. Please revert and double-check.

cfeck added a comment.Jan 7 2019, 9:20 PM

Oh, now I see: You would have needed to rebase your patch on current master, because Laurent already fixed clazy issues in many repositories. It's a bit unfortunate, but I cannot bother him to check all open code review requests while doing his cleanup work.

I am going to revert the last commit, no further action is needed.

Revision Contents
Changeset List

PathPackages
Mkcalc.cpp (62 lines)

Diff 48920

View Options

kcalc.cpp

Loading...