Differential D17776

Don't send our own notifications
ClosedPublic
Actions

Authored by nicolasfella on Dec 24 2018, 4:14 PM.

Details

Reviewers
albertvaka
Group Reviewers
KDE Connect
Commits
R225:501af459419a: Don't send our own notifications
Summary

They were silent anyway and are not really useful
BUG: 402490

Test Plan

I don't see the MPRIS notification in the plasmoid any more

Diff Detail

Repository
R225 KDE Connect - Android application
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella created this revision.Dec 24 2018, 4:14 PM
Restricted Application added a project: KDE Connect. · View Herald TranscriptDec 24 2018, 4:14 PM
Restricted Application added a subscriber: kdeconnect. · View Herald Transcript
nicolasfella requested review of this revision.Dec 24 2018, 4:14 PM
nicolasfella edited the summary of this revision. (Show Details)Dec 24 2018, 4:16 PM
albertvaka accepted this revision.Dec 24 2018, 9:20 PM
This revision is now accepted and ready to land.Dec 24 2018, 9:20 PM
Closed by commit R225:501af459419a: Don't send our own notifications (authored by nicolasfella). · Explain WhyDec 24 2018, 9:35 PM
This revision was automatically updated to reflect the committed changes.
nicolasfella mentioned this in R225:cd5bc17176e4: [ReceiveNotifications] Honor silent property.

Revision Contents
Changeset List

Diff 48160

View Options

src/org/kde/kdeconnect/Plugins/NotificationsPlugin/NotificationsPlugin.java

Loading...