Fix KIOClient non-interactive mode handling renamed prompts

Authored by davidedmundson on Dec 20 2018, 12:24 AM.



In the kdelibs to KF5 transition a factory class was added for loading
the rename prompts to make KIO gui-less.

In jobs "if (isInteractive)" was changed everywhere into "if

The former was false if we called KJob::setUiDelegate(nullptr). The
latter is only false if the calling code explicitly calls the new
KIO::Job::setUiDelegateExtension(nullptr) as well.

This left kioclient5 in the very weird state of non-interactive mode
still having rename dialogs but not error messages.

Now non-interactive mode will simply error if it hits a conflict and
stop as before.

Test Plan

Copied a conflict. Got a warning and an exit.
Interactive mode remains the same

Diff Detail

R126 KDE CLI Utilities
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
Restricted Application added a project: Plasma. · View Herald TranscriptDec 20 2018, 12:24 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson requested review of this revision.Dec 20 2018, 12:24 AM
davidedmundson edited the summary of this revision. (Show Details)Dec 20 2018, 12:33 AM
davidedmundson edited the test plan for this revision. (Show Details)
dfaure accepted this revision.Dec 20 2018, 10:18 AM
This revision is now accepted and ready to land.Dec 20 2018, 10:18 AM
This revision was automatically updated to reflect the committed changes.