Differential D17702

[mpriscontrol] add primitive windows support
ClosedPublic
Actions

Authored by jambon on Dec 19 2018, 10:42 PM.

Details

Reviewers
kdeconnect
albertvaka
Group Reviewers
KDE Connect
Maniphest Tasks
T10000: Media player control on Windows
Commits
R224:f4c7e12ea697: [mpriscontrol] add primitive windows support
Summary

Added primitive support for the mpriscontrol plugin on Windows by simulating VK_MEDIA key presses. I took a look into ISystemMediaTransportControls, but there doesn't seem to query it since it's per app. Leaving simulating key presses our only option for now. Completes T10000

Diff Detail

Repository
R224 KDE Connect
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
jambon created this revision.Dec 19 2018, 10:42 PM
Restricted Application added a project: KDE Connect. · View Herald TranscriptDec 19 2018, 10:42 PM
jambon requested review of this revision.Dec 19 2018, 10:42 PM
jambon added a reviewer: KDE Connect.Dec 19 2018, 10:43 PM
jambon added a project: Windows.
jambon edited the summary of this revision. (Show Details)Dec 19 2018, 10:54 PM
jambon edited the summary of this revision. (Show Details)
jambon edited the summary of this revision. (Show Details)Dec 19 2018, 11:04 PM
jambon updated this revision to Diff 47956.Dec 21 2018, 1:31 PM

Fixed Stuff

jambon updated this revision to Diff 47957.Dec 21 2018, 1:33 PM

More Fixes

albertvaka accepted this revision.Dec 21 2018, 5:25 PM
albertvaka added a subscriber: albertvaka.

Looks good to me.

plugins/mpriscontrol/mpriscontrolplugin-win.cpp
24

Can be defined inside the if.

This revision is now accepted and ready to land.Dec 21 2018, 5:25 PM
jambon updated this revision to Diff 47976.Dec 21 2018, 5:31 PM

Minor fix

jambon marked an inline comment as done.Dec 21 2018, 5:31 PM
Closed by commit R224:f4c7e12ea697: [mpriscontrol] add primitive windows support (authored by jambon, committed by albertvaka). · Explain WhyDec 21 2018, 6:24 PM
This revision was automatically updated to reflect the committed changes.
albertvaka added a comment.Dec 28 2018, 1:17 AM

You have a few merged patches already, so feel free to ask for a developer account if you want to have commit rights to land your own patches :)

https://community.kde.org/Infrastructure/Get_a_Developer_Account#How_to_get_read-write_access_to_git.2Fsvn

jambon added a comment.Dec 31 2018, 12:13 PM

Thanks, that would be very helpful.

Revision Contents
Changeset List

Diff 47978

View Options

plugins/CMakeLists.txt

Loading...
View Options

plugins/mpriscontrol/CMakeLists.txt

Loading...
View Options

plugins/mpriscontrol/mpriscontrolplugin-win.h

Loading...
View Options

plugins/mpriscontrol/mpriscontrolplugin-win.cpp

Loading...