Some repos like akonadi-search need special settings for creating a
dump.
Details
Diff Detail
- Repository
- R857 CI System Tooling
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
helpers/create-abi-dump.py | ||
---|---|---|
233–236 | We should probably document all the supported options somewhere central. | |
276–277 | Shouldn't this comment be updated to reflect the new arguments being passed to abi-compliance-checker? | |
303 | Spelling: abi-complience-checker -> abi-compliance-checker | |
304 | Code style: yaml.load( open(localMetadataPath) ) | |
helpers/helperslib/Settings.py | ||
5 ↗ | (On Diff #47813) | Could we follow the pattern from BuildSpecs here (which is similar, except it uses separate files per project/platform/etc) Also, i'm wondering if this module should be called something different to follow the convention of BuildSpecs (although admittedly this could be used for other things as well), perhaps something like ToolingSettings? |
10 ↗ | (On Diff #47813) | Unless 'default' means something special to a YAML indexer, won't this code fail to pick up the defaults? |
24 ↗ | (On Diff #47813) | Won't this lead to platform keys being imported into the configuration/settings dict we return? |
helpers/helperslib/Settings.py | ||
---|---|---|
5 ↗ | (On Diff #47813) | can you rephrase this? I don't get it what do you want. Is it just renaming the function? or the filename? hopefully this solotion is general enough to be used for more things. |
10 ↗ | (On Diff #47813) | this works just fine. see line18 here we add default to the beginning, so the dict is initialized with the values of default entry. tested it for akonadi ( default values should been returned) and akonadi-search (special values are returned) |
24 ↗ | (On Diff #47813) | yepp this is a side-effect, but it is just, that the dict has more entries. |
helpers/helperslib/Settings.py | ||
---|---|---|
5 ↗ | (On Diff #47813) | The first paragraph was referring to the function name. Usually we've followed a pattern of Class.load( file ) or equivalent. Settings.settings( ) doesn't really describe what it does (which the pattern of BuildSpecs does) For the second paragraph, I was referring to the filename (which python treats as the module name). Based on the code, I agree it should be usable for other things. |
10 ↗ | (On Diff #47813) | I see, okay. I didn't see that at first as it was under the sorting all entries comment. |
24 ↗ | (On Diff #47813) | That map in check-platforms is more to map things to an operating system. I'd suggest perhaps that the YAML gets structured something like this to solve this: "kde/pim/akonadi-search": general: gcc_options: - "-std=c++11" - "-fPIC" - "-DQT_NO_KEYWORDS" "SUSEQt5.10": # or overwrite the setting for one specific platform gcc_options: - "-bla" |
helpers/helperslib/Settings.py | ||
---|---|---|
10 ↗ | (On Diff #47813) | well I used a more elegant solution and used "*" entry in yaml file, than we don't need a special entry. |