Added a QSpinBox to adjust granularity while doing transforms
ClosedPublic
Actions

The patch looks basically correct, except that the option is related to cage transform only, so it is logical to put it into the "cage" page, but not to the free transform page. Right now it looks very confusing :)

Please move it to the Cage page :)

This revision now requires changes to proceed.Dec 25 2018, 6:31 AM

Moved the QSpinBox to Cage Transform Page of the Transform Tool

Hi, @hellozee!

The patch looks fine! Now you should add one more option for the preview granularity, but that is for the next patch :)

PS:
Right now the configuration is hardcoded in KisCageTransformStrategy::calculateTransformedImage()

This revision is now accepted and ready to land.Dec 25 2018, 1:47 PM

Thanks for the idea of another patch, I was having a hard time going through bugzilla to get one, 😛

Closed by commit R37:ea51095a4be8: Added a QSpinBox to adjust granularity while doing transforms (authored by hellozee, committed by dkazakov). · Explain WhyDec 25 2018, 2:06 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			plugins/tools/tool_transform2/kis_tool_transform_config_widget.h (2 lines)
M			plugins/tools/tool_transform2/kis_tool_transform_config_widget.cpp (9 lines)
M			plugins/tools/tool_transform2/kis_transform_utils.cpp (6 lines)
M			plugins/tools/tool_transform2/tool_transform_args.h (9 lines)
M			plugins/tools/tool_transform2/tool_transform_args.cc (1 line)
M			plugins/tools/tool_transform2/wdg_tool_transform.ui (84 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	47786			Dec 18 2018, 6:34 PM	★	★
Diff 2	48183			Dec 25 2018, 9:11 AM	★	★
Diff 3	48189	b56a036	R37:ea51095a4be8ddbb10aac9908fe3597dbd361a92	Dec 25 2018, 2:05 PM	★	★