Differential D17653

Keep kioclient alive whilst we're showing error messages
ClosedPublic
Actions

Authored by davidedmundson on Dec 18 2018, 1:05 PM.

Details

Reviewers
nerdopolist
broulik
Group Reviewers
Plasma
Commits
R126:c05e88533de1: Keep kioclient alive whilst we're showing error messages
Summary

QApplication::quit will close any open windows including error messages.

This keeps the process alive whilst we have a top level window.

Test Plan

Ran a kioclient script that produced an error dialog
It stayed on my screen

Diff Detail

Repository
R126 KDE CLI Utilities
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.Dec 18 2018, 1:05 PM
Restricted Application added a project: Plasma. · View Herald TranscriptDec 18 2018, 1:05 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson requested review of this revision.Dec 18 2018, 1:05 PM
broulik added a subscriber: broulik.Dec 18 2018, 1:13 PM
broulik added inline comments.
kioclient/kioclient.cpp
411–415

isEmpty()

davidedmundson marked an inline comment as done.Dec 18 2018, 1:40 PM
broulik accepted this revision.Dec 18 2018, 1:41 PM
This revision is now accepted and ready to land.Dec 18 2018, 1:41 PM
Closed by commit R126:c05e88533de1: Keep kioclient alive whilst we're showing error messages (authored by davidedmundson). · Explain WhyDec 20 2018, 11:04 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mkioclient/kioclient.cpp (6 lines)

Diff 47921

View Options

kioclient/kioclient.cpp

Loading...