Differential D1762

Call destroyWindowManagementInterface from ShellClient::destroyClient
ClosedPublic
Actions

Authored by graesslin on Jun 3 2016, 2:56 PM.

Details

Reviewers
bshah
Group Reviewers
Plasma
Commits
R108:0388ed02a6c5: Call destroyWindowManagementInterface from ShellClient::destroyClient
Summary

So far destroyWindowManagementInterface was only called when the
ShellClient got unmapped. But it's possible (although not recommended)
to just destroy the Surface without prior unmapping. In that case the
PlasmaWindow got leaked.

This change addresses this problem by always calling
destroyWindowManagementInterface from ShellClient::destroyClient.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
graesslin updated this revision to Diff 4197.Jun 3 2016, 2:56 PM
graesslin retitled this revision from to Call destroyWindowManagementInterface from ShellClient::destroyClient.
graesslin updated this object.
graesslin edited the test plan for this revision. (Show Details)
graesslin added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptJun 3 2016, 2:56 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
bshah accepted this revision.Jun 3 2016, 3:04 PM
bshah added a reviewer: bshah.
This revision is now accepted and ready to land.Jun 3 2016, 3:04 PM
Closed by commit R108:0388ed02a6c5: Call destroyWindowManagementInterface from ShellClient::destroyClient (authored by graesslin). · Explain WhyJun 6 2016, 6:39 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 4224

View Options

autotests/wayland/plasmawindow_test.cpp

Loading...
View Options

shell_client.cpp

Loading...