Differential D17615

[FolderView] Fix blurry icon labels
AbandonedPublic
Actions

Authored by filipf on Dec 16 2018, 1:13 AM.

Details

Reviewers
None
Group Reviewers
Plasma
Summary

C̶o̶m̶m̶i̶t̶ ̶5̶f̶c̶a̶2̶b̶3̶2̶c̶e̶5̶b̶ ̶i̶n̶t̶r̶o̶d̶u̶c̶e̶d̶ ̶a̶ ̶b̶u̶g̶ ̶w̶h̶i̶c̶h̶ ̶m̶a̶k̶e̶s̶ ̶s̶o̶m̶e̶ ̶i̶c̶o̶n̶ ̶l̶a̶b̶e̶l̶s̶ ̶b̶l̶u̶r̶r̶y̶.̶ ̶T̶h̶i̶s̶ ̶p̶a̶t̶c̶h̶ ̶i̶s̶ ̶a̶n̶ ̶a̶t̶t̶e̶m̶p̶t̶ ̶t̶o̶ ̶f̶i̶x̶ ̶i̶t̶.̶

BUG: 401048

Test Plan

Before:

After:

Diff Detail

Repository
R119 Plasma Desktop
Branch
fix-blurry-labels (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 6063
Build 6081: arc lint + arc unit
filipf created this revision.Dec 16 2018, 1:13 AM
Restricted Application added a project: Plasma. · View Herald TranscriptDec 16 2018, 1:13 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
filipf requested review of this revision.Dec 16 2018, 1:13 AM
filipf edited the summary of this revision. (Show Details)Dec 16 2018, 1:14 AM
filipf edited the test plan for this revision. (Show Details)
filipf added a reviewer: Plasma.

Disclaimer: I'm really new with code so I don't know if this is the right way to solve the problem, but at the very least I think it shows this if clause is causing issues.

filipf edited the summary of this revision. (Show Details)Dec 16 2018, 1:18 AM
filipf added a comment.Dec 16 2018, 1:43 AM

Side effect: fonts are thicker looking now, although they don't correspond to styles such as Medium or Bold.

filipf abandoned this revision.Dec 16 2018, 2:17 AM

Okay, so apparently 3526334e8234 already fixed the blurry labels, sorry.

filipf edited the summary of this revision. (Show Details)Dec 16 2018, 2:25 AM
filipf reclaimed this revision.Dec 16 2018, 10:25 AM
filipf added a subscriber: rooty.

I'm reopening this because in my tests 3526334e8234 does not fix icons becoming blurry when changing icon sizes and @rooty is reporting he still gets blurry text when renaming icons. Does not happen with this patch, however.

rooty added a comment.Dec 16 2018, 10:26 AM

yup i rename it and it turns all blurry, irrespective of where the panel is or how much the icons have been selected / moved around

rooty added a comment.EditedDec 16 2018, 10:58 AM

my bad, i just didn't copy the entire contents of the plasma-desktop/containments/desktop/package/contents/ui/code folder off of github (just the FolderItemDelegate.qml), it works fine now that it's all up to date

R119:3526334e8234 resolves the issue entirely

filipf abandoned this revision.Dec 16 2018, 10:59 AM

Revision Contents
Changeset List

Diff 47647

View Options

containments/desktop/package/contents/ui/FolderItemDelegate.qml

Loading...