Differential D1761

Port service menus to KFileItemAction
ClosedPublic
Actions

Authored by elvisangelaccio on Jun 3 2016, 2:22 PM.

Details

Reviewers

rthomsen

Maniphest Tasks

T984: Port service menus to KFileItemAction

Commits

R36:c369264d6c9b: Port service menus to KFileItemAction

Summary

The Compress and Extract service menus shown in Dolphin's context menu are now
provided by two new KFileItemAction plugins. This allows us to do a lot of
useful checks before actually showing the actions in the context menu.

This also allows us to stop hardcoding the supported mimetypes for the Extract
menu. This is actually needed in order to support the Extract menu when more
than one archive is selected. In this case Dolphin sends to the plugin the
generic 'application/octet-stream' mimetype, so we have to manually check
anyway the mimetype of any given URL.

Test Plan

Apply https://git.reviewboard.kde.org/r/128088/ to dolphin master
Make sure that the Compress and Extract menu are disabled in read-only folders
Make sure that Compress is not shown when right-clicking an archive
Uninstall zip/7z and make sure that 'Compress -> as ZIP' is not shown

Diff Detail

Repository

R36 Ark

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

elvisangelaccio updated this revision to Diff 4193.Jun 3 2016, 2:22 PM

elvisangelaccio retitled this revision from to Port service menus to KFileItemAction.

elvisangelaccio edited the test plan for this revision. (Show Details)

elvisangelaccio added a reviewer: rthomsen.

elvisangelaccio updated this object.

Restricted Application added a project: Ark. · View Herald TranscriptJun 3 2016, 2:22 PM

Restricted Application added a subscriber: kde-utils-devel. · View Herald Transcript

elvisangelaccio added a task: T984: Port service menus to KFileItemAction.Jun 3 2016, 2:23 PM

Thanks for working on this. I followed your testing steps and it works as expected (after deleting the two old .desktop files). I also tried various compress and extract actions from the service menus and everything seems to work.

Now we can consider re-adding the "Compress->Here (as RAR)" entry :)

This revision is now accepted and ready to land.Jun 5 2016, 9:30 AM

Closed by commit R36:c369264d6c9b: Port service menus to KFileItemAction (authored by elvisangelaccio). · Explain WhyJun 5 2016, 6:11 PM

This revision was automatically updated to reflect the committed changes.

elvisangelaccio mentioned this in R36:c369264d6c9b: Port service menus to KFileItemAction.

Revision Contents
Changeset List

		Path
M		app/CMakeLists.txt (28 lines)
D	M	app/ark_addtoservicemenu.desktop (179 lines)
D	M	app/ark_servicemenu.desktop.cmake (167 lines)
A	M	app/compressfileitemaction.h (54 lines)
A	M	app/compressfileitemaction.cpp (99 lines)
A	M	app/compressfileitemaction.json (15 lines)
A	M	app/extractfileitemaction.h (54 lines)
A	M	app/extractfileitemaction.cpp (103 lines)
A	M	app/extractfileitemaction.json (13 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	4193	65895fc		Jun 3 2016, 2:22 PM	★	★
Diff 2	4216	65895fc	rARKc369264d6c9ba2763b338f025c359c1b4c86f66e	Jun 5 2016, 5:50 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
76236df41b88	21bdabca6a1d	cb09c96e9aef	Elvis Angelaccio	Switch to json	Jun 3 2016, 2:08 PM
cb09c96e9aef	51ba37579c51	65895fc6b3b0	Elvis Angelaccio	Port service menus to KFileItemAction	Sep 24 2015, 3:20 PM