Differential D17585

Fix print preview in Kig
ClosedPublic
Actions

Authored by yurchor on Dec 14 2018, 7:36 PM.

Details

Reviewers
aacid
Group Reviewers
KDE Edu
Commits
R331:3f85b75497e2: Fix print preview in Kig
Summary

Currently, print preview shows nothing due to the lack of connection.

This patch tries to fix this.

Test Plan
  1. Open an example plot.
  2. Select "File -> Print preview". The print preview should be shown.

Diff Detail

Repository
R331 Kig
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
yurchor created this revision.Dec 14 2018, 7:36 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptDec 14 2018, 7:36 PM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
yurchor requested review of this revision.Dec 14 2018, 7:36 PM
aacid accepted this revision.Dec 15 2018, 10:46 AM
aacid added a subscriber: aacid.
aacid added inline comments.
kig/kig_part.cpp
885

We should not use our printer but the printer the signal gives us. So it should be

connect( &printPreview, &QPrintPreviewDialog::paintRequested, [this](QPrinter *p){

I'll fix this myself and push it, saves some roundtrip between you and me that adds no value.

This revision is now accepted and ready to land.Dec 15 2018, 10:46 AM
Closed by commit R331:3f85b75497e2: Fix print preview in Kig (authored by yurchor, committed by aacid). · Explain WhyDec 15 2018, 10:46 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mkig/kig_part.cpp (4 lines)

Diff 47612

View Options

kig/kig_part.cpp

Loading...