Use typedef threadID_t qint64 instead of hard-coding
Changes PlannedPublic

Authored by sredman on Dec 13 2018, 6:37 AM.

Details

Reviewers
nicolasfella
Group Reviewers
KDE Connect
Summary

Due to the recent fiasco with needing to change from qint32 to qint64 for threadID, it became painfully obvious that I ought to have avoided hard-coding from the beginning. This patch solves that problem.

Unfortunately, this patch cannot build due to qtdbuscpp2xml not understanding typedef threadID qint64;. We either need some way to manually add this information, or the Qt tool to be updated to understand typedef on dbus-compatible types.

Test Plan

N.B.: This patch cannot build at the current time

  • Build app
  • Verfiy SMS is able to send/receive as before

Diff Detail

Repository
R224 KDE Connect
Branch
threadID-typedef
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 5978
Build 5996: arc lint + arc unit
sredman created this revision.Dec 13 2018, 6:37 AM
Restricted Application added a project: KDE Connect. · View Herald TranscriptDec 13 2018, 6:37 AM
Restricted Application added a subscriber: kdeconnect. · View Herald Transcript
sredman requested review of this revision.Dec 13 2018, 6:37 AM
nicolasfella accepted this revision.Dec 18 2018, 1:29 AM
This revision is now accepted and ready to land.Dec 18 2018, 1:29 AM
sredman planned changes to this revision.Dec 18 2018, 2:03 AM

This revision cannot currently land: It needs either updated Qt Tools support (https://bugreports.qt.io/browse/QTBUG-72522) or we need to somehow upgrade our build system to allow custom types to be defined in the dbus XML