[Panel Configuration] Disallow pressing Escape whilst manipulating panel
ClosedPublic

Authored by broulik on Jun 3 2016, 8:58 AM.

Details

Summary

When dragging the panel around and pressing Escape, we might leave the panel in an inconsistent state, eg. somewhere in the middle of the screen.

Test Plan

Just running the reset animation doesn't work, so this is fair enough. Also usually pressing Escape during a drag would cancel the drag first but we cannot easily do that, so whatever. With this patch I can no longer leave my panel in the middle of the screen :)

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik updated this revision to Diff 4181.Jun 3 2016, 8:58 AM
broulik retitled this revision from to [Panel Configuration] Disallow pressing Escape whilst manipulating panel.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added a reviewer: Plasma.
broulik set the repository for this revision to R119 Plasma Desktop.
Restricted Application added a project: Plasma. · View Herald TranscriptJun 3 2016, 8:58 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart accepted this revision.Jun 3 2016, 9:11 AM
mart added a reviewer: mart.
This revision is now accepted and ready to land.Jun 3 2016, 9:11 AM
This revision was automatically updated to reflect the committed changes.