Differential D17485

Remove three classes form the SessionController header/source
ClosedPublic
Actions

Authored by tcanabrava on Dec 10 2018, 3:53 PM.

Details

Reviewers
hindenburg
Group Reviewers
Konsole
Commits
R319:d1e18d9dda39: Remove three classes form the SessionController header/source
Summary

Those three classes where *used* inside of the SessionController
but they where not supposed to be there. The code in the
SessionController is already too big to understand, so the removal
of unrelated code is a good thing: it's now easier to reason
about those other three classes without having to deal with
the whole code that the SessionController has.

Diff Detail

Repository
R319 Konsole
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
tcanabrava created this revision.Dec 10 2018, 3:53 PM
Restricted Application added a project: Konsole. · View Herald TranscriptDec 10 2018, 3:53 PM
Restricted Application added a subscriber: konsole-devel. · View Herald Transcript
tcanabrava requested review of this revision.Dec 10 2018, 3:53 PM
hindenburg accepted this revision.Dec 11 2018, 1:53 PM
This revision is now accepted and ready to land.Dec 11 2018, 1:53 PM
Closed by commit R319:d1e18d9dda39: Remove three classes form the SessionController header/source (authored by tcanabrava, committed by hindenburg). · Explain WhyDec 11 2018, 1:53 PM
This revision was automatically updated to reflect the committed changes.

Showing Only Differences

This revision modifies 9 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

Path
No data available.

Diff 47348