Find qplatformdefs.h for create-abi.
ClosedPublic

Authored by knauss on Dec 8 2018, 2:48 PM.

Details

Summary

The mkspecs directory is default Qt include directory. so we have to add
this. If we want to build ABIs for other devices, we would need to
modify this path accordingly.

Test Plan

At least mailcommon is building successfully building the abi dump.
kdav is also affected by this, but has other issues. kdav depends on KF5/kjs/CompileState.h, that includes "opcodes.h", which is not exported. (Will report this as bug against kjs).

Diff Detail

Repository
R857 CI System Tooling
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
knauss requested review of this revision.Dec 8 2018, 2:48 PM
knauss created this revision.
knauss edited the test plan for this revision. (Show Details)Dec 8 2018, 2:54 PM

We're only intending on monitoring the ABI on Linux correct?

knauss added a comment.Dec 9 2018, 1:19 PM

We're only intending on monitoring the ABI on Linux correct?

For the moment: surly, yes.

bcooksley accepted this revision.Dec 10 2018, 9:02 AM

Oki, looks good to me, this can go in.

This revision is now accepted and ready to land.Dec 10 2018, 9:02 AM
This revision was automatically updated to reflect the committed changes.