Differential D17412

[kcms/fonts] Don't set minimium DPI value
ClosedPublic
Actions

Authored by davidedmundson on Dec 7 2018, 6:24 PM.

Details

Reviewers
ngraham
Group Reviewers
Plasma
Commits
R119:61b6e098f825: [kcms/fonts] Don't set minimium DPI value
Summary

The QML port added a minimum value for the font DPI, the old widgets
code goes went 1 to 1000.

A slight bodge is needed to make sure we start at 96 when a user first
toggles force font DPI, which used to implicitly work as a minimum was
set.

BUG: 395575

Test Plan

Set different value, looked at xrdb -q | grep -i dpi
Cleared
set another value

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.Dec 7 2018, 6:24 PM
Restricted Application added a project: Plasma. · View Herald TranscriptDec 7 2018, 6:24 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson requested review of this revision.Dec 7 2018, 6:24 PM
ngraham accepted this revision.Dec 8 2018, 12:07 AM
ngraham added a subscriber: ngraham.

Works great!

This revision is now accepted and ready to land.Dec 8 2018, 12:07 AM
Closed by commit R119:61b6e098f825: [kcms/fonts] Don't set minimium DPI value (authored by davidedmundson). · Explain WhyDec 11 2018, 11:29 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 47342

View Options

kcms/fonts/package/contents/ui/main.qml

Loading...