Differential D17396

Add keywords to .desktop file
ClosedPublic
Actions

Authored by brettco on Dec 7 2018, 6:53 AM.

Details

Reviewers
ngraham
Group Reviewers
Spectacle
Commits
R166:dcb36a2fd3ad: Add keywords to .desktop file
Summary

FEATURE: 400989

The .desktop file for Spectacle doesn't have a "Keywords" entry. It would probably do well to provide Spectacle as a result when users search for 'Snipping Tool' as that's the Windows variant.

Test Plan

desktop-file-validate both before and after applying the patch

Diff Detail

Repository
R166 Spectacle
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
brettco requested review of this revision.Dec 7 2018, 6:53 AM
brettco created this revision.
pino added a subscriber: pino.Dec 7 2018, 8:29 AM

Please remove all the translations, since there is an automatic system that takes care of them.

brettco updated this revision to Diff 47049.Dec 7 2018, 5:25 PM

Removed translated portions

ngraham accepted this revision.Dec 8 2018, 4:09 AM
ngraham added a subscriber: ngraham.

Looks great, thanks! Can you provide your email address so I can land this patch with correct authorship information?

This revision is now accepted and ready to land.Dec 8 2018, 4:09 AM
brettco added a comment.Dec 8 2018, 4:54 AM

Weird, Phabricator must strip that information out. I used git format-patch and remember seeing my details....

Brett Cornwall
brett@i--b.com.

Thanks for the quick review!

ngraham added a comment.Dec 9 2018, 5:24 PM

Thanks for contributing to Spectacle! May it be the first of many more. :)

Closed by commit R166:dcb36a2fd3ad: Add keywords to .desktop file (authored by brettco, committed by ngraham). · Explain WhyDec 9 2018, 5:24 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mdesktop/org.kde.spectacle.desktop (1 line)

Diff 47193

View Options

desktop/org.kde.spectacle.desktop

Loading...