Added macsec setting according to:
https://developer.gnome.org/NetworkManager/stable/settings-macsec.html
Details
- Reviewers
jgrulich - Commits
- R282:b5a906ba5730: macsec setting
Diff Detail
- Lint
Lint Skipped - Unit
Unit Tests Skipped
autotests/settings/macsecsettingtest.cpp | ||
---|---|---|
30 | This required version is not true, please verify it properly, I'm not going to do it every time :). | |
src/settings/macsecsetting.cpp | ||
27 | Same wrong NM version as in the test. | |
312 | Flags should be inserted to the map all the time. | |
src/settings/macsecsetting.h | ||
59 | Can be turned into an enum. | |
71 | Can be turned into an enum. | |
src/settings/setting.cpp | ||
34 | Again not true. |
autotests/settings/macsecsettingtest.cpp | ||
---|---|---|
30 | I tried to get the version from here: Is that incorrect? | |
src/settings/macsecsetting.h | ||
59 | From where can I get the possible values? Because I cannot find them here: https://developer.gnome.org/NetworkManager/stable/settings-macsec.html |
src/settings/macsecsetting.h | ||
---|---|---|
59 | (I mean the default values to use in the defines) |
autotests/settings/macsecsettingtest.cpp | ||
---|---|---|
30 | That is probably incorrect, the easiest way how to search for this is to clone NetworkManager and checkout to a branch you want to check and grep the define you are looking for. So for example in my cloned NM, I go to "nm-1-6" branch and do "grep -ir NM_SETTING_MACSEC_MODE" and see that this property is defined there. You should check all NM versions so if it's defined in NM 1.6, I test also whether it is in NM 1.4. I usually start checking from the middle, which means "nm-1-8" branch and go to newer or older based on the result. | |
src/settings/macsecsetting.h | ||
59 | You can get it when you clone NetworkManager and go to the header file where these properties are defined. In your case it is in libnm-core/nm-setting-macsec.h. |
src/settings/macsecsetting.cpp | ||
---|---|---|
49 ↗ | (On Diff #47021) | Isn't default validation 2, which means "strict" in your case. |
294 ↗ | (On Diff #47021) | mode() > Macsec::Psk |
310 ↗ | (On Diff #47021) | validation() != Macsec::Strict |
src/settings/macsecsetting.h | ||
50 ↗ | (On Diff #47021) | In this case you don't need to define the defines above, just list both enums without assigned values, or you can just assign 0 to the first one to make sure it starts from 0. |
70 ↗ | (On Diff #47021) | const QString &mkaCak |
73 ↗ | (On Diff #47021) | const QString &mkaCkn |
79 ↗ | (On Diff #47021) | const QString &parent |