Fix use of QRegularExpressionMatch
ClosedPublic

Authored by fvogt on Dec 4 2018, 7:36 PM.

Details

Summary

isValid is always true in this case, leading to the wrong error message being
returned.

Test Plan

Opened the wizard, now it shows the correct error if a binary was
not found.

Diff Detail

Repository
R845 Plasma Vault
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
fvogt created this revision.Dec 4 2018, 7:36 PM
Restricted Application added a project: Plasma. · View Herald TranscriptDec 4 2018, 7:36 PM
fvogt requested review of this revision.Dec 4 2018, 7:36 PM
ivan accepted this revision.Dec 4 2018, 7:45 PM
This revision is now accepted and ready to land.Dec 4 2018, 7:45 PM
This revision was automatically updated to reflect the committed changes.

I have someone on IRC asking....

[12:46] <jubo2> Now got an issue.. Using the Plasma Vault the GUI complains about wrong versions of CryFS and alternatively wrong version of EncFS. I checked with 'apt show cryfs' and 'apt show encfs' and the installed versions are _newer_ than the one that Plasma Vaults is expecting. What to do / Can I proceed?

Is this the issue this fix is intended for>

fvogt added a comment.Dec 26 2018, 3:03 PM

Is this the issue this fix is intended for>

This diff fixes the issue that no matter what failed with invoking the binary, the "wrong version" error was shown.
For instance, if cryfs was not executable by the current user, it'd show that the version is too old.

So applying this won't suddenly make it work, but just show the correct message.