SceneXRender::Window uses a static XRenderPicture which it didn't clean up
ClosedPublic
Actions

Authored by graesslin on Jun 1 2016, 10:53 AM.

Details

Reviewers

sebas

Group Reviewers

Plasma

Commits

Summary

Using a static XRenderPicture results in a crash on exit as for cleanup
the already destroyed xcb_connection_t* is required.

This change ensures that the static XRenderPicture gets destroyed in the
static cleanup handler for SceneXRender::Window.

CCBUG: 363251

Repository

R108 KWin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

graesslin retitled this revision from to SceneXRender::Window uses a static XRenderPicture which it didn't clean up.

graesslin updated this object.

graesslin edited the test plan for this revision. (Show Details)

graesslin added a reviewer: Plasma.

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

LGTM

This revision is now accepted and ready to land.Jun 13 2016, 12:47 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			scene_xrender.h (1 line)
M			scene_xrender.cpp (13 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	4131	4548ba4		Jun 1 2016, 10:53 AM	★	★
Diff 2	4399	d49fba5	rKWIN1b40feca3a119f8d7098bff299cb8be4032fedda	Jun 13 2016, 1:29 PM	★	★