Differential D1732

[Kickoff] Use a single MouseArea for opening user manager
ClosedPublic
Actions

Authored by broulik on Jun 1 2016, 10:40 AM.

Details

Reviewers
sebas
Group Reviewers
Plasma
Commits
R119:feac04468de1: [Kickoff] Use a single MouseArea for opening user manager
Summary

Avoid code duplication which has already lead to inconsistencies.

BUG: 363528
FIXED-IN: 5.7.0

Test Plan

Chosed an avatar, click, worked
Removed my avatar, click, worked

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik updated this revision to Diff 4130.Jun 1 2016, 10:40 AM
broulik retitled this revision from to [Kickoff] Use a single MouseArea for opening user manager.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added a reviewer: Plasma.
broulik set the repository for this revision to R119 Plasma Desktop.
Restricted Application added a project: Plasma. · View Herald TranscriptJun 1 2016, 10:40 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik added a comment.Jun 1 2016, 10:41 AM

Probably better put that in 5.6.5 branch and then resolve the conflict by adding the new in 5.7

visible: KCMShell.authorize("user_manager.desktop").length > 0
sebas accepted this revision.Jun 1 2016, 10:11 PM
sebas added a reviewer: sebas.
This revision is now accepted and ready to land.Jun 1 2016, 10:11 PM
Closed by commit R119:feac04468de1: [Kickoff] Use a single MouseArea for opening user manager (authored by broulik). · Explain WhyJun 2 2016, 10:50 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 4161

View Options

applets/kickoff/package/contents/ui/Header.qml

Loading...