Differential D1728

Fix non-resizable infopanel when symlinks have a long target
ClosedPublic
Actions

Authored by elvisangelaccio on May 31 2016, 3:25 PM.

Details

Reviewers
rthomsen
Commits
R36:e04295523366: Fix non-resizable infopanel when symlinks have a long target
Summary

When a symbolic link points to an entry with a long filename, the infopanel
takes almost all available horizontal space and, even worse, cannot be resized.

This is because there is a single QLabel with a multi-line text, one of which
is the symlink's target. This patch replaces this label with a vertical
layout containing different labels. The targetLabel is now a KSqueezedTextLabel so
that a long target name won't mess up anymore the infopanel size.

BUG: 363719
FIXED-IN: 16.08.0

Test Plan

Open the archive attached in bug #363719.

Diff Detail

Repository
R36 Ark
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
elvisangelaccio updated this revision to Diff 4096.May 31 2016, 3:25 PM
elvisangelaccio retitled this revision from to Fix non-resizable infopanel when symlinks have a long target.
elvisangelaccio updated this object.
elvisangelaccio edited the test plan for this revision. (Show Details)
elvisangelaccio added a reviewer: rthomsen.
Restricted Application added a project: Ark. · View Herald TranscriptMay 31 2016, 3:25 PM
Restricted Application added a subscriber: kde-utils-devel. · View Herald Transcript
rthomsen accepted this revision.May 31 2016, 6:42 PM
rthomsen edited edge metadata.

Much better, thanks :)

This revision is now accepted and ready to land.May 31 2016, 6:42 PM

Revision Contents
Changeset List

PathPackages
Mpart/infopanel.h (2 lines)
Mpart/infopanel.cpp (36 lines)
Mpart/infopanel.ui (51 lines)

Diff 4125

View Options

part/infopanel.h

Loading...
View Options

part/infopanel.cpp

Loading...
View Options

part/infopanel.ui

Loading...