ovs-patch and ovs-port setting
ClosedPublic
Actions

src/settings/ovspatchsetting.cpp
73 ↗	(On Diff #46543)	Remove this space.
src/settings/ovspatchsetting.h
29 ↗	(On Diff #46543)	Move this please out of the header file and copy these defines to your test.
src/settings/ovsportsetting.h
28 ↗	(On Diff #46543)	Same with these defines. Move them ouf of the header.
src/settings/setting.cpp
129 ↗	(On Diff #46543)	I already added this missing break when pushing one of your changes.

pranavgade marked 4 inline comments as done.

autotests/settings/ovsportsettingtest.cpp
29	#if !NM_CHECK_VERSION(1, 10, 0)
src/settings/ovsportsetting.cpp
26	#if !NM_CHECK_VERSION(1, 10, 0)

pranavgade marked 2 inline comments as done.

jgrulich added inline comments.

autotests/settings/ovspatchsettingtest.cpp
31 ↗	(On Diff #46543)	This define is not necessary.
autotests/settings/ovsportsettingtest.cpp
31 ↗	(On Diff #46543)	This define is not necessary.

This revision is now accepted and ready to land.Dec 2 2018, 3:47 PM

This revision was automatically updated to reflect the committed changes.

Showing Only Differences

This revision modifies 7 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

		Path
A	M	autotests/settings/ovspatchsettingtest.cpp (63 lines)
A	M	autotests/settings/ovsportsettingtest.cpp (89 lines)
A	M	src/settings/ovspatchsetting.h (67 lines)
A	M	src/settings/ovspatchsetting.cpp (99 lines)
A	M	src/settings/ovsportsetting.h (80 lines)
A	M	src/settings/ovsportsetting.cpp (228 lines)
M		src/settings/setting.cpp (11 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	46543			Nov 30 2018, 10:43 AM	★	★
Diff 2	46674			Dec 2 2018, 9:35 AM	★	★
Diff 3	46708			Dec 2 2018, 2:21 PM	★	★
Diff 4	46719	d98e26f	R282:15670b62146f4e19faa5f146846c6d19649f9233	Dec 2 2018, 3:56 PM	★	★