ovs-patch and ovs-port setting
ClosedPublic
Actions

src/settings/ovspatchsetting.cpp
74	Remove this space.
src/settings/ovspatchsetting.h
30	Move this please out of the header file and copy these defines to your test.
src/settings/ovsportsetting.h
29	Same with these defines. Move them ouf of the header.
src/settings/setting.cpp
129	I already added this missing break when pushing one of your changes.

pranavgade marked 4 inline comments as done.

autotests/settings/ovsportsettingtest.cpp
30	#if !NM_CHECK_VERSION(1, 10, 0)
src/settings/ovsportsetting.cpp
27	#if !NM_CHECK_VERSION(1, 10, 0)

pranavgade marked 2 inline comments as done.

jgrulich added inline comments.

autotests/settings/ovspatchsettingtest.cpp
31	This define is not necessary.
autotests/settings/ovsportsettingtest.cpp
31	This define is not necessary.

This revision is now accepted and ready to land.Dec 2 2018, 3:47 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		autotests/settings/CMakeLists.txt (2 lines)
A	M	autotests/settings/ovspatchsettingtest.h (35 lines)
A	M	autotests/settings/ovspatchsettingtest.cpp (62 lines)
A	M	autotests/settings/ovsportsettingtest.h (35 lines)
A	M	autotests/settings/ovsportsettingtest.cpp (87 lines)
M		src/CMakeLists.txt (2 lines)
A	M	src/settings/ovspatchsetting.h (67 lines)
A	M	src/settings/ovspatchsetting.cpp (99 lines)
A	M	src/settings/ovspatchsetting_p.h (42 lines)
A	M	src/settings/ovsportsetting.h (80 lines)
A	M	src/settings/ovsportsetting.cpp (227 lines)
A	M	src/settings/ovsportsetting_p.h (47 lines)
M		src/settings/setting.h (4 lines)
M		src/settings/setting.cpp (10 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	46543			Nov 30 2018, 10:43 AM	★	★
Diff 2	46674			Dec 2 2018, 9:35 AM	★	★
Diff 3	46708			Dec 2 2018, 2:21 PM	★	★
Diff 4	46719	d98e26f	R282:15670b62146f4e19faa5f146846c6d19649f9233	Dec 2 2018, 3:56 PM	★	★