ovs-bridge and ovs-interface setting
ClosedPublic
Actions

src/settings/ovsbridgesetting.cpp
26	Add defines for ovs-bridge properties and name in case NM is older than NM 1.10.0.
28	Coding style.
155	Why this is commented out?
src/settings/ovsbridgesetting.h
36	Represents ovs-bridge setting
src/settings/ovsinterfacesetting.cpp
26	Add define for NM_SETTING_OVS_INTERFACE_SETTING_NAME in case NM is older than 1.10.0.
28	Coding style.
90	Why this is commented out?
src/settings/ovsinterfacesetting.h
36	Represents ovs-interface setting

Made the required changes

src/settings/ovsinterfacesetting.cpp
28	I forgot that the same problem will be with NM_SETTING_OVS_INTERFACE_TYPE. Define it too please.

pranavgade marked an inline comment as done.

This revision was not accepted when it landed; it landed in state Needs Review.Nov 30 2018, 11:30 AM

This revision was automatically updated to reflect the committed changes.

Showing Only Differences

This revision modifies 6 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

		Path
M		autotests/settings/CMakeLists.txt (2 lines)
M		src/CMakeLists.txt (2 lines)
A	M	src/settings/ovsbridgesetting.h (76 lines)
A	M	src/settings/ovsbridgesetting.cpp (169 lines)
A	M	src/settings/ovsinterfacesetting.h (67 lines)
A	M	src/settings/ovsinterfacesetting.cpp (100 lines)
M		src/settings/setting.h (4 lines)
M		src/settings/setting.cpp (10 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	46491			Nov 29 2018, 4:46 PM	★	★
Diff 2	46537			Nov 30 2018, 9:08 AM	★	★
Diff 3	46542			Nov 30 2018, 10:35 AM	★	★
Diff 4	46547	d2531a3	R282:2d72fc8c496ccf839ad4c1082eb7b5688f714a51	Nov 30 2018, 11:04 AM	★	★