ovs-bridge and ovs-interface setting
ClosedPublic

Authored by pranavgade on Nov 29 2018, 4:47 PM.

Diff Detail

Repository
R282 NetworkManagerQt
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
pranavgade created this revision.Nov 29 2018, 4:47 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptNov 29 2018, 4:47 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
pranavgade requested review of this revision.Nov 29 2018, 4:47 PM
jgrulich added inline comments.Nov 30 2018, 6:36 AM
src/settings/ovsbridgesetting.cpp
26

Add defines for ovs-bridge properties and name in case NM is older than NM 1.10.0.

28

Coding style.

155

Why this is commented out?

src/settings/ovsbridgesetting.h
36

Represents ovs-bridge setting

src/settings/ovsinterfacesetting.cpp
26

Add define for NM_SETTING_OVS_INTERFACE_SETTING_NAME in case NM is older than 1.10.0.

28

Coding style.

90

Why this is commented out?

src/settings/ovsinterfacesetting.h
36

Represents ovs-interface setting

pranavgade updated this revision to Diff 46537.Nov 30 2018, 9:08 AM
pranavgade marked 8 inline comments as done.

Made the required changes

jgrulich added inline comments.Nov 30 2018, 10:32 AM
src/settings/ovsinterfacesetting.cpp
28

I forgot that the same problem will be with NM_SETTING_OVS_INTERFACE_TYPE. Define it too please.

pranavgade marked an inline comment as done.
This revision was not accepted when it landed; it landed in state Needs Review.Nov 30 2018, 11:30 AM
This revision was automatically updated to reflect the committed changes.