[Task Manager] Move apps to activities from the context menu
AbandonedPublic

Authored by thsurrel on Nov 27 2018, 10:53 PM.

Details

Reviewers
hein
Group Reviewers
Plasma
Summary

The task manager context menu offers to _add_ applications to
activities, but the main use case is to _move_ an application to
another activity. This fixes the problem of having to open the
context menu twice to do this.

BUG: 401437

Test Plan

Right click on a application in the task manager, then select
Move To Activity and select another activity than the current one.
The application should be move right away.

Diff Detail

Repository
R119 Plasma Desktop
Branch
arc_activities (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 5452
Build 5470: arc lint + arc unit
thsurrel created this revision.Nov 27 2018, 10:53 PM
Restricted Application added a project: Plasma. · View Herald TranscriptNov 27 2018, 10:53 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
thsurrel requested review of this revision.Nov 27 2018, 10:53 PM
hein added a comment.Nov 29 2018, 3:52 PM

Does this mean you can't use the menu to add the window to multiple activities anymore?

thsurrel added a comment.EditedNov 29 2018, 4:01 PM

Yes, indeed. But it is just a proposal.
This patch mimics what is done for desktops: you can move a window to a desktop or to all of them. You lose the ability to add a window to an activity, but do we have a strong use case for that ? I personally always want to _move_ a window to another activity when I use this menu.

The alternative is to not close the context menu when we click on a activity, but I did not find how to do that.

hein added a comment.Nov 29 2018, 4:04 PM

Well, the entire point of activities existing is that they go beyond the limitations of desktops - you can add a window to 2 out of 5 activities, not just one or all. If it's the same, we don't need both.

thsurrel abandoned this revision.Nov 29 2018, 4:12 PM

I use it differently then ! :)