Differential D17196

Explicitly import Qt 5.7's QtQuick for Connections.enabled
ClosedPublic
Actions

Authored by heikobecker on Nov 27 2018, 6:41 PM.

Details

Reviewers
apol
Group Reviewers
Okular
Commits
R223:140638a0b360: Explicitly import Qt 5.7's QtQuick for Connections.enabled
Summary

It was introduced in that version and apparently Qt 5.12 is stricter
about this and causes 'qrc:/package/contents/ui/main.qml:59
"Connections.enabled" is not available in QtQuick 2.1.' when trying
to start okularkirigami without this patch.

Test Plan

okularkirigami shows up

Diff Detail

Repository
R223 Okular
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
heikobecker created this revision.Nov 27 2018, 6:41 PM
Restricted Application added a project: Okular. · View Herald TranscriptNov 27 2018, 6:41 PM
Restricted Application added a subscriber: okular-devel. · View Herald Transcript
heikobecker requested review of this revision.Nov 27 2018, 6:41 PM
apol accepted this revision.Nov 27 2018, 7:34 PM

LGTM

This revision is now accepted and ready to land.Nov 27 2018, 7:34 PM
Closed by commit R223:140638a0b360: Explicitly import Qt 5.7's QtQuick for Connections.enabled (authored by heikobecker). · Explain WhyNov 27 2018, 7:40 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 46342

View Options

mobile/app/package/contents/ui/main.qml

Loading...