Differential D17183

Show an empty column for the return on investment if the value cannot be calculated
ClosedPublic
Actions

Authored by habacker on Nov 27 2018, 10:52 AM.

Details

Reviewers
tbaumgart
Commits
R261:546e5e7cf16b: Show an empty column for the return on investment if the value cannot be…
Summary

There is a difference between 0.0% return and values, that are not
calculable because some prerequisites may not be fulfilled.

Cherry-picked from branch 4.8, commit 5816a0a18.

Diff Detail

Repository
R261 KMyMoney
Branch
5.0
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 5415
Build 5433: arc lint + arc unit
habacker requested review of this revision.Nov 27 2018, 10:52 AM
habacker created this revision.
tbaumgart accepted this revision.Nov 27 2018, 11:27 AM

Looks OK to me. Just did visual inspection.

This revision is now accepted and ready to land.Nov 27 2018, 11:27 AM
Closed by commit R261:546e5e7cf16b: Show an empty column for the return on investment if the value cannot be… (authored by habacker). · Explain WhyNov 27 2018, 11:56 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 46306

View Options

kmymoney/plugins/views/reports/core/querytable.h

Loading...
View Options

kmymoney/plugins/views/reports/core/querytable.cpp

Loading...